Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable ResourceHandlerTest for range requests and fix. #12418

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

janbartel
Copy link
Contributor

The ResourceHandlerTest had range requests disabled; re-enabled them and fixed test as necessary.

@janbartel janbartel requested review from gregw and joakime October 23, 2024 05:27
@janbartel janbartel self-assigned this Oct 23, 2024
@janbartel
Copy link
Contributor Author

@joakime @gregw this test was checking for the presence of a Content-Length header even when the request specified multiple ranges. Based on previous jetty behaviour, and code comments eg https://github.com/jetty/jetty.project/blob/jetty-11.0.x/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceService.java#L792 it looks like it is incorrect to expect a Content-Length header, so I removed those checks.

@janbartel janbartel mentioned this pull request Oct 23, 2024
39 tasks
@joakime
Copy link
Contributor

joakime commented Oct 23, 2024

@joakime @gregw this test was checking for the presence of a Content-Length header even when the request specified multiple ranges. Based on previous jetty behaviour, and code comments eg https://github.com/jetty/jetty.project/blob/jetty-11.0.x/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceService.java#L792 it looks like it is incorrect to expect a Content-Length header, so I removed those checks.

Yeah, remove it for Jetty 12.
I think the response buffering in Jetty 11 helped make this particular response have a Content-Length header.

@joakime
Copy link
Contributor

joakime commented Oct 23, 2024

Interesting, JDK23 timed out at 3 hours 30 minutes for this PR.

https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/detail/PR-12418/1/pipeline/

I kicked off rebuild, lets see what happens.

Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think jenkins is dead or dying

LGTM

@janbartel janbartel merged commit 1e9aca4 into jetty-12.1.x Oct 24, 2024
10 of 11 checks passed
@janbartel janbartel deleted the jetty-12.1.x-fix-ResourceHandlerTest branch October 24, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants